Re: [RFC][PATCH 04/10] cifs: define server-level cache index objects and register them with FS-Cache

From: David Howells
Date: Wed Jun 23 2010 - 12:55:11 EST


Suresh Jayaraman <sjayaraman@xxxxxxx> wrote:

> Define server-level cache index objects (as managed by TCP_ServerInfo
> structs). Each server object is created in the CIFS top-level index object
> and is itself an index into which superblock-level objects are inserted.
>
> Currently, the server objects are keyed by hostname.
>
> Signed-off-by: Suresh Jayaraman <sjayaraman@xxxxxxx>

Looks reasonable, apart from the index key. I agree with Jeff that you
probably want {address,port,family} rather than a hostname.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/