Re: [PATCH v2] security: Yama LSM

[Andi Kleen]

On Wed, Jun 23, 2010 at 07:54:37AM -0700, Kees Cook wrote:
> Oh, er, I actually added these configs because Eric Paris recommended them
> as handy for distributions.  I'm fine with dropping them, but will I be

Distributions should use init scripts for that imho.

> asked to add them back later?  And what about the case of CONFIG_SYSCTL
> being unset?

"depends on SYSCTL"

> 
> > However the help texts are useful,  these should be in the sysctl
> > documentatin in Documentation instead.
> 
> I documented the sysctls in Documentation/Yama.txt (where SELinux.txt and
> Smack.txt live) should I create an additional file in Documentation/sysctl/
> with that information (moved from Yama.txt) or move Yama.txt there?

Ok missed that. what you prefer.

> I actually think this is a flaw in get_task_comm.  (Though actually it's
> the fault of terminals if they process dangerous escape sequences. Worst
> case tends to just be confusing output, but that's not important --
> nothing should spew non-printables regardless.)  Would a patch to
> get_task_comm be accepted to replace non-printables with "?" or something
> when filling the buffer?

Probably makes sense, although you might annoy someone who wants Kanji
process names in UTF-8 or similar.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/