Re: [PATCH UPDATED] sched: adjust when cpu_active and cpuset configurationsare updated during cpu on/offlining

[Tejun Heo]

Hello,

On 06/21/2010 08:28 PM, Tony Luck wrote:
> On Tue, Jun 8, 2010 at 12:46 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
>> * Ingo's test discovered __cpuinit/exit markups were incorrect.
>>  Fixed.
> 
> No it isn't :-(

Ah, sorry, my original patch was broken on x86 too, so...

>> +static int __cpuexit cpuset_cpu_active(struct notifier_block *nfb,
>> +                                      unsigned long action, void *hcpu)
> ...
>> +static int __cpuexit cpuset_cpu_inactive(struct notifier_block *nfb,
>> +                                        unsigned long action, void *hcpu)
> 
> This patch arrived in linux-next (tag next-20100621) and breaks the
> ia64 build for configurations where CONFIG_HOTPLUG_CPU=n
> with the following cryptic error:
> 
> `.cpuexit.text' referenced in section `.IA_64.unwind.cpuexit.text' of
> kernel/built-in.o: defined in discarded section `.cpuexit.text' of
> kernel/built-in.o
> 
> This is because ia64 link stage drops __exit functions from
> built-in code (under the logic that they can never be called).
> 
> Is the problem in the !CONFIG_HOTPLUG_CPU definition of
> hotcpu_notifier() in <linux/cpu.h> which still references the
> function argument:
> 
> #define hotcpu_notifier(fn, pri)        do { (void)(fn); } while (0)
> 
> Or should these functions not be marked __cpuexit?

I see.  I think the right solution is removing __cpuexit but it's kind
of silly to have different rules on different architectures.  On x86,
__cpuexit currently means "you can drop it if you're not gonna be
removing cpus after system boot"; IOW, __cpuexit is strict subset of
__cpuinit.  If you define it as "don't include it in the text at all
if cpus are not gonna be removed", it actually forces you to carry
more text in the running system.  Is there any reason ia64 drops them
during linking?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/