Re: [PATCH 3/6]cifs Fix variable not set warnings

From: Justin P. Mattock
Date: Sun Jun 20 2010 - 09:29:09 EST


On 06/20/2010 06:22 AM, Alessandro Guido wrote:
...
@@ -734,7 +733,6 @@ cifs_lookup(struct inode *parent_dir_inode, struct
dentry *direntry,
direntry->d_op =&cifs_dentry_ops;
d_add(direntry, newInode);
if (posix_open)
- filp = lookup_instantiate_filp(nd, direntry, NULL);
/* since paths are not looked up by component - the parent
directories are presumed to be good here */
renew_parental_timestamps(direntry);
...

This is wrong, now "renew_parental_timestamps(direntry)" is in the if body.




have you had a chance to look at the later one I had sent in yesterday?
if so out of the two, which might be a better bet(keep in mind the first set has whitespace issues).

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/