Re: [PATCH 1/5] vmlinux.lds.h: Include *(.text.*) in TEXT_TEXT

[James Bottomley]

On Thu, 2010-06-17 at 22:19 +0200, Denys Vlasenko wrote:
> >> This is doable in asm, yes. For .bss, we need to not forget about
> >> @nobits too: section .bss.foo,"aw",@nobits
> >
> > That's only for bss ... we have about a handful of such statements and
> > they always use the assembler .bss directive (which doesn't need flags).
> >
> >> > Actually, as I said, that would be .data-
> 
> You are right, in assembly we can specify needed attributes.
> 
> I am more concerned about C:
> 
> arch/x86/include/asm/cache.h:
> #define __read_mostly __attribute__((__section__(".data..read_mostly")))
> 
> If we change it to
> 
> #define __read_mostly __attribute__((__section__(".data-read_mostly")))
> 
> What makes this section have correct attributes?

The fact that we specify it correctly in the sectional gather in the
linker scripts.  i.e. we should have a (NOLOAD) type for the
gathered .bss section ... although currently we don't.

The point (for the third time) is that if our linker scripts specify the
sections and attributes absolutely (and correctly) it doesn't matter
what random attributes the .o files pick up.  It's only if we miss a
specifier that the linker tries to work it out from the input sections.

That's how we make postfix or any other type of "nonstandard" section
name work.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/