Re: [PATCH 1/2] arm: msm: Add gpiolib support for MSM7200A-familychips.

[Daniel Walker]

On Thu, 2010-06-17 at 13:04 -0700, Greg Bean wrote:
> >> +config MSM7200A_GPIO
> >> +	tristate "Qualcomm MSM7200A SoC GPIO support"
> >> +	depends on GPIOLIB
> >> +	help
> >> +	  Say yes here to support GPIO functionality on Qualcomm's
> >> +	  MSM chipsets which descend from the MSM7200a:
> >> +	  MSM7x01(a), MSM7x25, MSM7x27, MSM7x30, QSD8x50(a).
> >
> > Can't we drop this? It's always going to be on right ?
> 
> Not on all targets.  There will be other drivers for chips from other 
> lines.  However, I would think that it could be entirely reasonable to 
> lose the Kconfig and just hard-wire it in based on ARCH, if you like. 
> Is that preferred?

Yeah, it's better not to have Kconfig options like this since it's
easier for the user if we just encode this into options we know they
have to select already.

So for example they pick 8x50 via Kconfig, so we select for them the
right stuff for 8x50 .. Otherwise we have to assume they know what to
select which may not be the case, plus it could be a pain to go
selecting all the related Kconfig options for low level stuff.

If you respin this please re-send it privately just to me.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/