Re: [patch] x86, pat: freeing invalid memtype messages

[Dan Carpenter]

On Thu, Jun 17, 2010 at 06:17:28PM +0200, Marcin Slusarz wrote:
> On Thu, Jun 17, 2010 at 03:45:59PM +0200, Dan Carpenter wrote:
> > Commit 20413f27163 "x86, pat: Fix memory leak in free_memtype" added an
> > error message in free_memtype() if rbt_memtype_erase() returns NULL.  
> > The problem is that if CONFIG_X86_PAT is enabled, we use a different
> > implimentation of rbt_memtype_erase() that always returns NULL.
> > 
> > I've modified rbt_memtype_erase() to return an ERR_PTR() on errors and 
> > made free_memtype() check for that instead.
> > 
> > Addresses:  https://bugzilla.kernel.org/show_bug.cgi?id=16205
> > 
> > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> This patch is probably ok, but it does not address my bug.
> I have CONFIG_X86_PAT=y, so rbt_memtype_erase does not always return NULL.
>  

Uh.  Yeah.  Crap.  I'm an idiot.

regrds,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/