Re: [PATCH] Slabinfo: Fix display format

[Christoph Lameter]

On Thu, 17 Jun 2010, wzt.wzt@xxxxxxxxx wrote:

> @@ -4271,7 +4271,7 @@ static int s_show(struct seq_file *m, void *p)
>  	if (error)
>  		printk(KERN_ERR "slab: cache %s error: %s\n", name, error);
>
> -	seq_printf(m, "%-17s %6lu %6lu %6u %4u %4d",
> +	seq_printf(m, "%-27s %6lu %6lu %6u %4u %4d",
>  		   name, active_objs, num_objs, cachep->buffer_size,
>  		   cachep->num, (1 << cachep->gfporder));
>  	seq_printf(m, " : tunables %4u %4u %4u",

This one may break user space tools that have assumptions about the length
of the field. Or do tools not make that assumption?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/