Re: bnx2 fails to compile on parisc because of missingget_dma_ops()

[FUJITA Tomonori]

On Wed, 16 Jun 2010 18:16:32 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: James Bottomley <JBottomley@xxxxxxxxxx>
> Date: Wed, 16 Jun 2010 20:13:49 -0500
> 
> > However, this code in bnx2.c:
> > 
> > 		if (!get_dma_ops(&pdev->dev)->sync_single_for_cpu) {
> > 			next_rx_buf =
> > 				&rxr->rx_buf_ring[
> > 					RX_RING_IDX(NEXT_RX_BD(sw_cons))];
> > 			prefetch(next_rx_buf->desc);
> > 		}
> > 
> > Looks remarkably fragile: what exactly is it trying to do?
> > 
> > The commit that causes the problem:
> > 
> > commit a33fa66bcf365ffe5b79d1ae1d3582cc261ae56e
> > Author: Michael Chan <mchan@xxxxxxxxxxxx>
> > Date:   Thu May 6 08:58:13 2010 +0000
> > 
> >     bnx2: Add prefetches to rx path.
> > 
> > Looks fairly innocuous by the description.
> > 
> > Should parisc have a get_dma_ops()?  We don't need one because our dma
> > ops are per platform not per bus.
> 
> I think asking for get_dma_ops() directly in a driver is dodgy at
> best, especially one that is meant to compile on any PCI supporting
> system.  At least right now.

Yeah, it should be used only in the architecture core
code. get_dma_ops() is not mentioned in DMA-API-* docs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/