Re: [PATCH 1/2] x86: ioremap: fix wrong physical address handling
From: H. Peter Anvin
Date: Thu Jun 17 2010 - 00:22:43 EST
On 06/16/2010 07:50 PM, Matthew Wilcox wrote:
On Thu, Jun 17, 2010 at 10:30:06AM +0900, Kenji Kaneshige wrote:
Index: linux-2.6.34/arch/x86/mm/ioremap.c
===================================================================
--- linux-2.6.34.orig/arch/x86/mm/ioremap.c 2010-06-15 04:43:00.978332015 +0900
+++ linux-2.6.34/arch/x86/mm/ioremap.c 2010-06-15 05:32:59.291693007 +0900
@@ -62,8 +62,8 @@
static void __iomem *__ioremap_caller(resource_size_t phys_addr,
unsigned long size, unsigned long prot_val, void *caller)
{
- unsigned long pfn, offset, vaddr;
- resource_size_t last_addr;
+ unsigned long offset, vaddr;
+ resource_size_t pfn, last_pfn, last_addr;
I have a hard time understanding this change. pfn is always a physical
address shifted by PAGE_SHIFT. So a 32-bit pfn supports up to 44-bit
physical addresses. Are your addresses above 44-bits?
I think they might be. Kenji?
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/