Re: [PATCH] x86: OLPC: add support for calling into OpenFirmware(v3)

[H. Peter Anvin]

On 06/16/2010 12:13 PM, Andres Salomon wrote:
> @@ -658,6 +664,10 @@ ENTRY(stack_start)
>  	.long init_thread_union+THREAD_SIZE
>  	.long __BOOT_DS
>  
> +.globl olpc_ofw_pgd
> +olpc_ofw_pgd:
> +	.long olpc_ofw_pgd
> +
>  ready:	.byte 0
>  

This variable doesn't need to be initialized, and so belongs .bss.  You
don't need to declare it in an assembly file at all; it probably makes
more sense to just declare it a normal variable (possibly __init) inside
olpc_ofw.c.

Otherwise it's starting to look good.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/