Re: [PATCH] d_ino considered harmful

[Valerie Aurora]

On Wed, Jun 16, 2010 at 03:15:56PM -0400, Jeff Layton wrote:
> On Wed, 16 Jun 2010 14:59:13 -0400
> Valerie Aurora <vaurora@xxxxxxxxxx> wrote:
> 
> > Who needs d_ino anyway?  I am running a kernel with this patch -
> > Gnome, a browser, IRC, kernel compile, etc. and everything works.
> > 
> > -VAL
> > 
> > commit 184f3919d0071f3bfa40010aa6919ea89999d79b
> > Author: Valerie Aurora <vaurora@xxxxxxxxxx>
> > Date:   Wed Jun 16 11:05:06 2010 -0700
> > 
> >     VFS: Always return 0 for d_ino
> >     
> >     Use of d_ino without the corresponding st_dev is always buggy in the
> >     presence of submounts, bind mounts, and union mounts.  E.g., the d_ino
> >     of a mountpoint will be the inode number of the directory under the
> >     mountpoint, not the mounted directory.  Correct code must call stat(),
> >     which returns the correct device ID and inode in st_dev and st_ino.
> >     Since no one should be using d_ino anyway, always return 0 to detect
> >     bugs.
> > 
> > diff --git a/fs/readdir.c b/fs/readdir.c
> > index dd3eae1..38ea772 100644
> > --- a/fs/readdir.c
> > +++ b/fs/readdir.c
> > @@ -91,7 +91,9 @@ static int fillonedir(void * __buf, const char * name, int namlen, loff_t offset
> >  
> >  	if (buf->result)
> >  		return -EINVAL;
> > -	d_ino = ino;
> > +	/* Use of d_ino without st_dev is always buggy. */
> > +	d_ino = 0;
> > +
> >  	if (sizeof(d_ino) < sizeof(ino) && d_ino != ino) {
> >  		buf->result = -EOVERFLOW;
> >  		return -EOVERFLOW;
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> That may run afoul of the following check (where d_ino is compared to
> ino). You can probably just remove that check though since you can be
> reasonably sure that 0 will never overflow the field.

You're right, I included that in the next version of the patch.

Thanks,

-VAL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/