Re: [RFC PATCH] mm: let the bdi_writeout fraction respond morequickly

[Peter Zijlstra]

On Mon, 2010-06-14 at 15:44 +0100, Richard Kennedy wrote:
> > diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> > index 2fdda90..315dd04 100644
> > --- a/mm/page-writeback.c
> > +++ b/mm/page-writeback.c
> > @@ -144,7 +144,7 @@ static int calc_period_shift(void)
> >       else
> >               dirty_total = (vm_dirty_ratio * determine_dirtyable_memory()) /
> >                               100;
> > -     return 2 + ilog2(dirty_total - 1);
> > +     return ilog2(dirty_total - 1) - 4;
> >  } 

IIRC I suggested similar things in the past and all we needed to do was
find people doing the measurements on different bits of hardware or so..

I don't have any problems with the approach, all we need to make sure is
that we never return 0 or a negative number (possibly ensure a minimum
positive shift value).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/