Re: [PATCH] drivers:staging: sources for ST core

From: Greg KH
Date: Tue Mar 30 2010 - 18:39:54 EST


On Wed, Mar 31, 2010 at 02:35:55AM +0530, Pavan Savoy wrote:
> So, something like the below is ok, I have defined my own pr_fmt,
> however default log level on my board is 7, and hence pr_info is a bit
> more annoying than usual.

No, a driver should use dev_dbg() and other dev_printk() calls, not
pr_debug() or anything like that.

Please don't roll your own formats, use the ones that are well defined
and uniquely describe your driver and device in a format that the whole
kernel uses.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/