Re: [PATCH] dma-mapping: Remove WARN_ON in dma_free_coherent

[Stefan Bader]

Matthew Wilcox wrote:
> On Mon, Mar 29, 2010 at 08:09:21PM +0200, Stefan Bader wrote:
>> But it seems modifying that driver would be a bigger effort and maybe
>> not really worthwile as it is a rather old driver. On the other side
>> I was told [1] that this WARN_ON applies only to ARM which could sleep
>> in the free path and it is just bogus for X86. As the code is in
>> arch/x86 it would never be used for anything else than X86 and if
>> its truely bogus on X86, couldn't it get removed?
> 
> My suggestion was that you remove it from the Ubuntu kernel, not submit
> it upstream.
> 
No, I did not want to give that impression. But my rational was, that if this is
 really a warning that has no meaning on X86, then why should it stay in code
that is x86 only. And then why should that not go upstream.
When I tried following the code, it looked like this was carried forward for
quite a while and maybe it just stayed because nobody noticed it.
But with KVM using that scsi driver, other distros might see the same bogus
warning and then it would be beneficial for all to just remove it.
If Ingo or hpa say it is needed, ok. But its at least worth a go.

-Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/