linux-next: build failure after merge of the slabh tree

From: Stephen Rothwell
Date: Mon Mar 29 2010 - 02:13:37 EST


Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

kernel/debug/kdb/kdb_support.c: In function 'kdb_strdup':
kernel/debug/kdb/kdb_support.c:309: error: implicit declaration of function 'kmalloc'
kernel/debug/kdb/kdb_support.c:309: warning: initialization makes pointer from integer without a cast
kernel/debug/kdb/kdb_support.c: In function 'debug_kfree':
kernel/debug/kdb/kdb_support.c:810: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 5572dd736e5577dfefafe2ad3b54760e8323e33d ("kdb: core for kgdb
back end (1 of 2)") from the kgdb tree.

I applied the following merge fixup patch which should be applied to the
kdbg tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Date: Mon, 29 Mar 2010 15:49:05 +1100
Subject: [PATCH] kgdb: use of kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
---
kernel/debug/kdb/kdb_support.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index 788dbfe..45344d5 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -24,6 +24,7 @@
#include <linux/delay.h>
#include <linux/uaccess.h>
#include <linux/kdb.h>
+#include <linux/slab.h>
#include "kdb_private.h"

/*
--
1.7.0.3

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/