Re: [PATCH 1/3] X86: Optimise fls(), ffs() and fls64()

From: Linus Torvalds
Date: Fri Mar 26 2010 - 13:47:29 EST




On Fri, 26 Mar 2010, Scott Lurndal wrote:
>
> I wonder if Intel's EM64 stuff makes this more deterministic, perhaps
> David's implementation would work for x86_64 only?

Limiting it to x86-64 would certainly remove all the worries about all the
historical x86 clones.

I'd still worry about it for future Intel chips, though. I absolutely
_detest_ relying on undocumented features - it pretty much always ends up
biting you eventually. And conditional writeback is actually pretty nasty
from a microarchitectural standpoint.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/