Re: [PATCH 14/16] Tools perf probe-finder.c: duplicated include

From: Masami Hiramatsu
Date: Thu Mar 25 2010 - 13:42:54 EST


Hi Andrea,

Andrea Gelmini wrote:
> tools/perf/util/probe-finder.c: string.h is included more than once.

Would you mean that <string.h> and "string.h" are duplicated?
If so, NAK, sorry. Those are different, <string.h> is for
/usr/include/string.h, and "string.h" is for tools/perf/util/string.h.

Thank you,

>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@xxxxxxxxx>
> ---
> tools/perf/util/probe-finder.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index 1e6c65e..682eb37 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -32,7 +32,6 @@
> #include <stdarg.h>
> #include <ctype.h>
>
> -#include "string.h"
> #include "event.h"
> #include "debug.h"
> #include "util.h"

--
Masami Hiramatsu
e-mail: mhiramat@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/