Re: [PATCH] fat: fix buffer overflow in vfat_create_shortname()

From: OGAWA Hirofumi
Date: Thu Mar 25 2010 - 08:33:52 EST


Nikolaus Schulz <microschulz@xxxxxx> writes:

>> However, anyway, your patch is much better off than current one. So,
>> I'll apply this in the next merge window.
>>
>> Or should we apply this immediately?
>>
>> Thanks.
>
> Given that this fixes a stack corruption which triggers the gcc stack
> smashing protection and thus basically a crash, I vote for not
> postponing it, but applying it immediately.

Um..., where is a stack corruption? sprintf() overflow? But, it's
actually snprintf(), not sprintf()...

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/