Re: [PATCH] perf_events: fix remapped count support

[Stephane Eranian]

On Tue, Mar 23, 2010 at 6:41 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Tue, 2010-03-23 at 18:25 +0200, Stephane Eranian wrote:
>> Â Â Â Â This patch fixes the remapped counter support such that it now works
>> Â Â Â Â on X86 processors.
>
> (could you please not add all this whitespace in front? and make sure
> Âit's no wider than 70 chars)
>
I will fix that.

> Also, I wouldn't say it fixes it, it's currently not broken, its plain
> not implemented. So this patch adds support for rdpmc.
>
There you go, then.

>> Â Â Â Â For other architectures, e.g., PPC, SPARC, assuming they do offer the ability
>> Â Â Â Â to read counts directly from user space, all that is needed is a couple of new
>> Â Â Â Â arch specific functions:
>
> Power already supports this, so if you just broke this Paul is going to
> be unhappy.
>
I certainly changed the content of hdr->offset. But I don't see how
PPC could have this working otherwise in the presence of multiplex
and thus when you need the timing information to scale.

I'll wait for Paul's comments, then.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/