Re: [PATCH] smp_call_function_many SMP race

From: Anton Blanchard
Date: Tue Mar 23 2010 - 17:31:37 EST



Hi Peter,

> A rather simple question since my brain isn't quite ready processing the
> content here..

After working my way through that bug my brain wasn't in good shape
either because:

> Isn't reverting that one patch a simpler solution than adding all that
> extra logic? If not, then the above statement seems false and we had a
> bug even with that preempt_enable/disable() pair.

I screwed up the explanation :( The commit message that causes it is
54fdade1c3332391948ec43530c02c4794a38172 (generic-ipi: make struct
call_function_data lockless), and backing it out fixes the issue.

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/