[PATCH -mm 2/2] keyctl_session_to_parent: use thread_group_empty()to check singlethreadness

From: Oleg Nesterov
Date: Tue Mar 23 2010 - 10:51:07 EST


No functional changes.

keyctl_session_to_parent() is the only user of signal->count which needs
the correct value. Change it to use thread_group_empty() instead, this
must be strictly equivalent under tasklist, and imho looks better.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
---

security/keys/keyctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- 34-rc1/security/keys/keyctl.c~MISC_2_KEYCTL 2009-12-18 19:05:38.000000000 +0100
+++ 34-rc1/security/keys/keyctl.c 2010-03-23 15:21:00.000000000 +0100
@@ -1269,7 +1269,7 @@ long keyctl_session_to_parent(void)
goto not_permitted;

/* the parent must be single threaded */
- if (atomic_read(&parent->signal->count) != 1)
+ if (!thread_group_empty(parent))
goto not_permitted;

/* the parent and the child must have different session keyrings or

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/