Re: [PATCH 12/12] add CPU notifier error injection module

[Akinobu Mita]

2010/3/23 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:
> On Thu, 18 Mar 2010 18:05:24 +0900
> Akinobu Mita <akinobu.mita@xxxxxxxxx> wrote:
>
>> I used this module to test the series of modification to the
>> cpu notifiers code.
>>
>> Example1: inject CPU offline error (-1 == -EPERM)
>>
>>       # modprobe cpu-notifier-error-inject cpu_down_prepare_error=-1
>>       # echo 0 > /sys/devices/system/cpu/cpu1/online0
>>       bash: echo: write error: Operation not permitted
>>
>> Example2: inject CPU online error (-2 == -ENOENT)
>>
>>       # modprobe cpu-notifier-error-inject cpu_up_prepare_error=-2
>>       # echo 1 > /sys/devices/system/cpu/cpu1/online0
>>       bash: echo: write error: No such file or directory
>>
>> ...
>>
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -885,6 +885,18 @@ config LKDTM
>>       Documentation on how to use the module can be found in
>>       Documentation/fault-injection/provoke-crashes.txt
>>
>> +config CPU_NOTIFIER_ERROR_INJECT
>> +     tristate "CPU notifier error injection module"
>> +     depends on HOTPLUG_CPU && DEBUG_KERNEL
>> +     help
>> +       This option provides a kernel module that can be used to test
>> +       the error handling of the cpu notifiers
>> +
>> +       To compile this code as a module, choose M here: the module will
>> +       be called cpu-notify-inject.
>
> Should be "cpu-notifier-error-inject", yes?

Yes. Thanks for spotting and fixing.
And I had another typos in the above patch description:

>> Example1: inject CPU offline error (-1 == -EPERM)
>>
>>       # modprobe cpu-notifier-error-inject cpu_down_prepare_error=-1
>>       # echo 0 > /sys/devices/system/cpu/cpu1/online0

# echo 0 > /sys/devices/system/cpu/cpu1/online

(s/online0/online/)

>>       bash: echo: write error: Operation not permitted
>>
>> Example2: inject CPU online error (-2 == -ENOENT)
>>
>>       # modprobe cpu-notifier-error-inject cpu_up_prepare_error=-2
>>       # echo 1 > /sys/devices/system/cpu/cpu1/online0

Ditto.

>>       bash: echo: write error: No such file or directory
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/