Re: [PATCH 1/5] cpufreq: Unify sysfs attribute definition macros

[Thomas Renninger]

On Tuesday 23 March 2010 12:44:09 Borislav Petkov wrote:
> From: Thomas Renninger <trenn@xxxxxxx>
> Date: Tue, Mar 23, 2010 at 12:07:29PM +0100
> 
> > > +#define define_one_global_ro(_name)		\
> > > +static struct global_attr _name =		\
> > > +__ATTR(_name, 0444, show_##_name, NULL)
> > > +
> > > +#define define_one_global_rw(_name)		\
> > > +static struct global_attr _name =		\
> > > +__ATTR(_name, 0644, show_##_name, store_##_name)
> > 
> > These sound like too general names in global space.
> > And are unrelated to cpufreq(.h).
> 
> maybe call them cpufreq_define_(global|freq)_* then?
> 
> > Eventually you get them into sysfs.h with another name
> > or just duplicate them?
> 
> Well, struct freq_attr for example is cpufreq-specific attribute,
> AFAICT. So, keeping them in cpufreq.h should be fine, no?
You don't need much of these (one or two?).
I'd leave this cleanup out for your patch series.
You care about the boost and aperf/mperf stuff and not about this
cleanup?

    Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/