Re: [RFC Patch 2/3] bridge: make bridge support netpoll

[Cong Wang]

David Miller wrote:
> From: Cong Wang <amwang@xxxxxxxxxx>
> Date: Tue, 23 Mar 2010 12:39:35 +0800
>
> > How could you let the bridge know netpoll is not sent to
> > the one that doesn't support netpoll during setup? This will
> > be complex, I am afraid.
>
> Why does this matter at all?

Because currently we check netpoll support by ->ndo_poll_controller,
for example, tap driver doesn't have ->ndo_poll_controller now,
if I choose the target "@192.168.0.2/br0" where "192.168.0.2" is owned
by "tap0" which is managed by "br0", netconsole may not work.


> I told you in another mail that we should do away with
> these callbacks and all the crazy 'npinfo' assignments
> and just do it in the generic code.

I think ->ndo_poll_controller is not in the case that you talked about.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/