Re: [Patch v2] netpoll: warn when there are spaces in parameters

From: Cong Wang
Date: Mon Mar 22 2010 - 21:41:30 EST


Matt Mackall wrote:
On Mon, 2010-03-22 at 04:59 -0400, Amerigo Wang wrote:
+ printk(KERN_INFO "%s: warning: whitespace"
+ "is not allowed\n", np->name);

Is it a warning or is it info? If it's a warning, then we probably need
to add "netpoll" or whatever to the message so that people who've got a
warning-level threshold will know what it's about.


If you mean KERN_INFO, yeah, I want to keep it in the same level
as other messages around.

Also, I already put "np->name" which will be "netconsole" when
we use netconsole.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/