Re: CrystalHD driver safe on big endian systems?

[Leon Woestenberg]

Hello Scott and others,

On Mon, Mar 22, 2010 at 4:53 AM, Scott D. Davilla <davilla@xxxxxxx> wrote:
>
> <..> From what I've seen in code, it looks definite little endian based and would need
> a look over regarding byte swap.
>
What parts of the code assumes little endian from what you've seen?

Now, byte swap endianess is one thing, C bitfields in combination with
it, another. I have given it a first shot here (mailer unsuitable for
sending patches), still failed on PowerPC:
http://www.sidebranch.com/crystalhd/

May I suggest we instrument all register access functions with a
printk() of the register being written? Then I can compare little
endian access patterns with big endian, to be sure we get the
bitfields, code assumptions and byte swap correctly.

Regards,
-- 
Leon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/