Re: [PATCH] Route kbd LEDs through the generic LEDs layer (5thversion)

[Pavel Machek]

Hi!

> Route keyboard LEDs through the generic LEDs layer.
> 
> This permits to reassign keyboard LEDs to something else than keyboard "leds"
> state, by adding keyboard led and modifier triggers connected to a series
> of global input LEDs, themselves connected to global input triggers, which
> per-input device LEDs use by default.  Userland can thus easily change the LED
> behavior of (a priori) all input devices, or of particular input devices.
> 
> This also permits to fix #7063 from userland by using a modifier to implement
> proper CapsLock behavior and have the keyboard caps lock led show that modifier
> state.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

I like it.

Tested-by: Pavel Machek <pavel@xxxxxx>

Now, minor comments:

sometimes it uses "numl" (led name), sometimes it uses "numlock"
trigger name.

root@amd:/sys/class/leds/input5::numl# echo heartbeat > trigger

did not do the trick on my thinkpad. It still acts as numlock led. Is
it driven by hw? input5::capsl works as expected.

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/