Re: [PATCH] staging: winbond: reg.c Coding style fixes.

From: Lars Lindley
Date: Sun Mar 21 2010 - 11:40:46 EST


Hi Pekka

I will check them more in the future.
I will come back with a new patch against master that combines the two commits
as soon as I get my head around how to get git to combine them.. :)
(And paint the little room in the appartment.. :)

/Lars

On 2010-03-21 13:39, Pekka Enberg wrote:
> Pavel Machek wrote:
>>> [PATCH] staging: winbond: reg.c Fix accidental commenting of msleep(10)
>>>
>>> I accidentaly commented out msleep() in one place.
>>> This applies after previous patch:
>>> Message-Id: <1269098051-6594-1-git-send-email-lindley@xxxxxxxxxx>
>>>
>>> Signed-off-by: Lars Lindley <lindley@xxxxxxxxxx>
>>
>> Ack. but you probably want to merge those two pieces together.
>
> Yes. Like I said before, please _check_ the result before posting your
> patches. It's very easy to make silly mistakes in "trivial" patches like
> these. Remember, it's not about quantity, it's about quality of each
> individual patch no matter how trivial they might seem at first.
>
> Pekka
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/