Re: [PATCH 4/4] pci/dmar: Tone down warnings about invalid BIOSDMAR tables

[David Woodhouse]

On Sat, 2010-03-20 at 23:07 +0000, Ben Hutchings wrote:
> We now know how to deal with these tables so that they are harmless.
> Use the TAINT_FIRMWARE_WORKAROUND flag and don't say the BIOS is
> 'broken' as this makes users think of hardware damage.

Nack to the string change. If you see this message, it's because your
BIOS is BROKEN, and this brokenness has caused us to have to disable the
VT-d feature completely. The fuckwits obviously never tested it even as
far as booting a VT-d enabled OS on it even onceÂ.

We _want_ people to think of it as hardware damage and return the board
to the vendor, as unfit for the purpose for which it was sold.

The rest of the series looks good though; thanks.

I haven't applied the first patch, although it stands alone -- your
other patches will depend on it and cause merge pain. Or do you want me
to take the whole lot through the intel-iommu tree?

-- 
dwmw2

 Or maybe they did, but the OS didn't tell them clearly enough that it
  was broken.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/