Re: [Regression, post-2.6.34-rc1][PATCH] x86 / perf: Fix suspendto RAM on HP nx6325

[Peter Zijlstra]

On Sat, 2010-03-20 at 21:48 +0100, Rafael J. Wysocki wrote:
> On Saturday 20 March 2010, Linus Torvalds wrote:
> > 
> > On Sat, 20 Mar 2010, Peter Zijlstra wrote:
> > >  
> > >  	cpuhw = &per_cpu(cpu_hw_events, cpu);
> > > +	if (!cpuhw)
> > > +		return;
> > 
> > How can an address-of expression be NULL?
> > 
> > Yes, 'per_cpu()' is magic, but it shouldn't be possible to be _that_ 
> > magic. It's rather against the whole C model.
> 
> Yeah.
> 
> A field in the object pointed to by it can be NULL, though.

That's what I was aiming for,. might have missed it by a mile though :/

> The appended patch fixes the breakage for me too.

ok, works for me, thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/