Re: [PATCH] PCI: create function symlinks in /sys/bus/pci/slots/N/

[Yinghai Lu]

On Sat, Mar 20, 2010 at 10:52 AM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Fri, Mar 19, 2010 at 2:46 PM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
>> On Mon, 8 Mar 2010 10:24:29 -0700
>> Alex Chiang <achiang@xxxxxx> wrote:
>>
>>> Create convenience symlinks in sysfs, linking slots to device
>>> functions, and vice versa. These links make it easier for users to
>>> figure out which devices actually live in what slots.
>>>
>>> For example:
>>
>> Applied to linux-next, thanks.
>
> looks this one cause
>
> [  225.210695] calling  pci_sysfs_init+0x0/0x51 @ 1
> [  225.224774] ------------[ cut here ]------------
> [  225.228913] WARNING: at fs/sysfs/dir.c:451 sysfs_add_one+0xd9/0xf3()
> [  225.245349] Hardware name: Sun Fire x4800
> [  225.247894] sysfs: cannot create duplicate filename
> '/devices/pci0000:00/0000:00:03.0/0000:02:00.0/slot'
> [  225.268122] Modules linked in:
> [  225.270966] Pid: 1, comm: swapper Not tainted
> 2.6.34-rc2-tip-yh-03489-gae232d1-dirty #684
> [  225.286652] Call Trace:
> [  225.288878]  [<ffffffff81079c04>] warn_slowpath_common+0x7c/0x94
> [  225.306239]  [<ffffffff81079c73>] warn_slowpath_fmt+0x41/0x43
> [  225.310655]  [<ffffffff811868ff>] sysfs_add_one+0xd9/0xf3
> [  225.326012]  [<ffffffff8118753a>] sysfs_do_create_link+0xce/0x13c
> [  225.330730]  [<ffffffff81186114>] ? sysfs_create_file+0x2a/0x2c
> [  225.346429]  [<ffffffff811875cd>] sysfs_create_link+0x13/0x16
> [  225.350303]  [<ffffffff813ee209>] pci_create_sysfs_dev_files+0x28e/0x3a1
> [  225.367131]  [<ffffffff826c4c1a>] pci_sysfs_init+0x1f/0x51
> [  225.382825]  [<ffffffff826c4bfb>] ? pci_sysfs_init+0x0/0x51
> [  225.388122]  [<ffffffff826c4bfb>] ? pci_sysfs_init+0x0/0x51
> [  225.403175]  [<ffffffff826c4bfb>] ? pci_sysfs_init+0x0/0x51
> [  225.407330]  [<ffffffff8100020d>] do_one_initcall+0x72/0x17f
> [  225.423173]  [<ffffffff8269b6d6>] do_basic_setup+0x54/0x66
> [  225.428494]  [<ffffffff8269b782>] kernel_init+0x9a/0x111
> [  225.443106]  [<ffffffff81bfa7ae>] ? trace_hardirqs_on_thunk+0x3a/0x3f
> [  225.447205]  [<ffffffff810349d4>] kernel_thread_helper+0x4/0x10
> [  225.464053]  [<ffffffff81bfb63c>] ? restore_args+0x0/0x30
> [  225.467298]  [<ffffffff8269b6e8>] ? kernel_init+0x0/0x111
> [  225.483514]  [<ffffffff810349d0>] ? kernel_thread_helper+0x0/0x10
> [  225.487928] ---[ end trace c9d3fb1a8a3caa22 ]---
>
> the system has pcie hotplug support.

revert that patch, make the warning go away.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/