Re: [PATCH 2/4 v2] MFD: add support for the RDC321x southbridge

[Stephen Rothwell]

Hi Florian,

On Fri, 19 Mar 2010 13:52:09 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 11 Mar 2010 09:42:09 +0100
> Florian Fainelli <florian@xxxxxxxxxxx> wrote:
> 
> > +static struct pci_device_id rdc321x_sb_table[] = {
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_RDC, PCI_DEVICE_ID_RDC_R6030) },
> > +	{}
> > +};
> 
> should be const, methinks.

In fact maybe even

static DEFINE_PCI_DEVICE_TABLE(rdc321x_sb_table) = {
	...

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature