Re: [PATCH] perf_events: fix ordering bug in perf_output_sample()

[Peter Zijlstra]

On Thu, 2010-03-18 at 14:42 +0200, Stephane Eranian wrote:
> 	In order to parse a sample correctly based on the information
> 	requested via sample_type, the kernel needs to save each component
> 	in a known order. There is no type value saved with each component.
> 	The current convention is that each component is saved according to
> 	the order in enum perf_event_sample_format. But perf_output_sample()
> 	was not completely following this convention, thereby making samples
> 	impossible to parse without internal kernel knowledge.
> 
> 	This patch puts things in the right order.

NAK, not so actually, its in the order specified in the
PERF_RECORD_SAMPLE comment.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/