Re: [PATCH] perf: fix stat attach bogus counts

[stephane eranian]

On Thu, Mar 18, 2010 at 6:36 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Stephane Eranian <eranian@xxxxxxxxxx> wrote:
>
>> Â Â Â When perf stat -p pid is used, the events must be enabled
>> Â Â Â immediately as there is no exec and thus no enable_on_exec.
>>
>> Â Â Â Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
>>
>> --
>> Âbuiltin-stat.c | Â Â6 ++++--
>> Â1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
>> index 95db31c..3a91fad 100644
>> --- a/tools/perf/builtin-stat.c
>> +++ b/tools/perf/builtin-stat.c
>> @@ -159,8 +159,10 @@ static void create_perf_stat_counter(int counter, int pid)
>> Â Â Â Â Â Â Â }
>> Â Â Â } else {
>>        attr->inherit    Â= inherit;
>> -       attr->disabled    = 1;
>> - Â Â Â Â Â Â attr->enable_on_exec = 1;
>> + Â Â Â Â Â Â if (target_pid == -1) {
>> +           attr->disabled    = 1;
>> + Â Â Â Â Â Â Â Â Â Â attr->enable_on_exec = 1;
>> + Â Â Â Â Â Â }
>
> Mind checking latest -tip, which has these commits:
>
> d6d901c: perf events: Change perf parameter --pid to process-wide collection instead of thread-wid
> 46be604: perf record: Enable counters only when kernel is execing subcommand
> 6be2850: perf stat: Enable counters when collecting process-wide or system-wide data
>
> as they fix/improve various --pid related behavioral aspects of perf. Does it
> work fine for you now?
>
They indeed included the same fix.
So that's fine now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/