Re: [PATCH][RF C/T/D] Unmapped page cache control - via boot parameter

[Avi Kivity]

On 03/17/2010 06:58 PM, Christoph Hellwig wrote:
> On Wed, Mar 17, 2010 at 06:53:34PM +0200, Avi Kivity wrote:
>    
> > Meanwhile I looked at the code, and it looks bad.  There is an
> > IO_CMD_FDSYNC, but it isn't tagged, so we have to drain the queue before
> > issuing it.  In any case, qemu doesn't use it as far as I could tell,
> > and even if it did, device-matter doesn't implement the needed
> > ->aio_fsync() operation.
> >      
> No one implements it, and all surrounding code is dead wood.  It would
> require us to do asynchronous pagecache operations, which involve
> major surgery of the VM code.  Patches to do this were rejected multiple
> times.
>    

Pity.  What about the O_DIRECT aio case?  It's ridiculous that you can 
submit async write requests but have to wait synchronously for them to 
actually hit the disk if you have a write cache.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/