[Patch] netpoll: allow spaces in its parameter

From: Amerigo Wang
Date: Wed Mar 17 2010 - 01:53:33 EST



It would be nice if we allow spaces in netconsole parameters,
otherwise we get weird results if there are spaces in it.

After this patch, we will allow things like:
"netconsole= @192.168.0.1/eth0 , 66666@xxxxxxxxxxx/".

Signed-off-by: WANG Cong <amwang@xxxxxxxxxx>
Cc: David Miller <davem@xxxxxxxxxxxxx>

---
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7aa6972..bf3b2f0 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -629,6 +629,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
char *cur=opt, *delim;

if (*cur != '@') {
+ cur = skip_spaces(cur);
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;
*delim = 0;
@@ -651,12 +652,14 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
if ((delim = strchr(cur, ',')) == NULL)
goto parse_failed;
*delim = 0;
+ strim(cur);
strlcpy(np->dev_name, cur, sizeof(np->dev_name));
cur = delim;
}
cur++;

if (*cur != '@') {
+ cur = skip_spaces(cur);
/* dst port */
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/