Re: [PATCH 02/11] mm,migration: Do not try to migrate unmapped anonymous pages

[KAMEZAWA Hiroyuki]

On Wed, 17 Mar 2010 13:15:14 +0900
Minchan Kim <minchan.kim@xxxxxxxxx> wrote:

> On Wed, Mar 17, 2010 at 12:15 PM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
> > On Wed, 17 Mar 2010 12:00:15 +0900
> > Minchan Kim <minchan.kim@xxxxxxxxx> wrote:
> >
> >> On Wed, Mar 17, 2010 at 11:12 AM, KAMEZAWA Hiroyuki
> >> > BTW, I doubt freeing anon_vma can happen even when we check mapcount.
> >> >
> >> > "unmap" is 2-stage operation.
> >> > Â Â Â Â1. unmap_vmas() => modify ptes, free pages, etc.
> >> > Â Â Â Â2. free_pgtables() => free pgtables, unlink vma and free it.
> >> >
> >> > Then, if migration is enough slow.
> >> >
> >> > Â Â Â ÂMigration(): Â Â Â Â Â Â Â Â Â Â Â Â Â ÂExit():
> >> > Â Â Â Âcheck mapcount
> >> > Â Â Â Ârcu_read_lock
> >> > Â Â Â Âpte_lock
> >> > Â Â Â Âreplace pte with migration pte
> >> > Â Â Â Âpte_unlock
> >> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âpte_lock
> >> > Â Â Â Âcopy page etc... Â Â Â Â Â Â Â Â Â Â Â Âzap pte (clear pte)
> >> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âpte_unlock
> >> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âfree_pgtables
> >> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â->free vma
> >> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â->free anon_vma
> >> > Â Â Â Âpte_lock
> >> > Â Â Â Âremap pte with new pfn(fail)
> >> > Â Â Â Âpte_unlock
> >> >
> >> >    Âlock anon_vma->lock       # modification after free.
> >> > Â Â Â Âcheck list is empty
> >>
> >> check list is empty?
> >> Do you mean anon_vma->head?
> >>
> > yes.
> >
> >> If it is, is it possible that that list isn't empty since anon_vma is
> >> used by others due to
> >> SLAB_DESTROY_BY_RCU?
> >>
> > There are 4 cases.
> > Â Â Â ÂA) anon_vma->list is not empty because anon_vma is not freed.
> > Â Â Â ÂB) anon_vma->list is empty because it's freed.
> > Â Â Â ÂC) anon_vma->list is empty but it's reused.
> > Â Â Â ÂD) anon_vma->list is not empty but it's reused.
> 
> E) anon_vma is used for other object.
> 
> That's because we don't hold rcu_read_lock.
> I think Mel met this E) situation.
> 
Hmm. 

> AFAIU, even slab page of SLAB_BY_RCU can be freed after grace period.
> Do I miss something?
> 
I miss something. Sorry for noise.

Maybe we need check page_mapped() before calling try_to_unmap() as
vmscan does. Thank you for your help.

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/