Re: [PATCH] err.h: add __must_check to error pointer handlers

From: Alexey Dobriyan
Date: Fri Mar 12 2010 - 13:41:04 EST


On Fri, Mar 12, 2010 at 03:45:40PM +0200, Jani Nikula wrote:
> Add __must_check to error pointer handlers to have the compiler warn
> about mistakes like:
>
> if (err)
> ERR_PTR(err);

> -static inline void *ERR_PTR(long error)
> +static inline void * __must_check ERR_PTR(long error)

We had bugs like that?

Pretty much every non-void function should be marked then.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/