Re: [PATCH] irq: move some interrupt arch_* functions into structirq_chip.

From: Ian Campbell
Date: Wed Mar 10 2010 - 13:28:22 EST


On Wed, 2010-03-10 at 18:15 +0000, Eric W. Biederman wrote:
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> writes:
>
> > On Wed, 2010-03-10 at 17:42 +0000, Eric W. Biederman wrote:
> >>
> >>
> >> Ian Xen in this sense is simply not x86. irq_cfg is not acpi or
> >> ioapic or anything but x86 specific. It has everything to do with
> >> having a per cpu vector table of 256 entries and architecturally
> >> receiving a vector number when an interrupt is fired.
> >>
> >> It totally makes sense for Xen to do something different because
> >> architecturally it has a completely different irq subsystem.
> >
> > OK, so that sounds like you would like the same patchset but without the
> > irq_cfg renaming? or potentially with renaming to x86_blah instead (I'll
> > rework to your preference).
>
> Currently the renaming really makes it unclear what you are doing and for
> some reason the description of the renaming rubbed me the wrong way.

Sorry, I started off a bit confused and then totally misunderstood what
related to what and I think that came through in the description.

I'll respin without the first patch.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/