Re: Tuxradar patching article and [PATCH]scripts/cvt_kernel_style.pl

From: Joe Perches
Date: Tue Mar 09 2010 - 19:34:26 EST


On Tue, 2010-03-09 at 15:41 -0800, Greg KH wrote:
> I _really_ dislike automatic source conversions by a tool and do not
> recommend doing that at all.

On Tue, 2010-03-09 at 16:16 -0800, Greg KH wrote:
> > You take automatic conversions from tools like coccinelle all
> > the time.
> Those are sane, as they are tiny and obvious :)

You contradict yourself.

> It's the huge "reformat the whole file with indent" type stuff
> that I object to.

Which is sensible and not what you lead with.

Any conversion done an automatic tool should be limited to
a specific type of change and should not be done wholesale.

Scripts like what I posted are easy to limit to specific
types of conversion. Tools like Lindent are not.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/