Re: [PATCH 0/2] small xhci cleanups

From: Greg KH
Date: Tue Mar 09 2010 - 13:14:25 EST


On Tue, Mar 09, 2010 at 10:52:43AM -0700, Alex Chiang wrote:
> While trying to render aid and assistance for a USB3 issue that Sarah
> has been chasing, she grumbled in a private email that she was unable
> to coerce the build system to produce a module named "xhci_hcd".
>
> This patch series shows one way to get around the Makefile intrinsics
> and create a module name of our choosing. There's probably a better
> way to do it, but it's beyond my makefile-fu.
>
> The other change is to move all the debug code under
> CONFIG_XHCI_HCD_DEBUGGING, which is a straightforward change.
>
> Thanks,
> /ac
>
> ---
>
> Alex Chiang (2):
> USB: xhci: rename driver to xhci_hcd

I'm not opposed to this at all, but note, we should do it _now_ and not
hold on to this patch for the rest of the .34 development cycle
otherwise people are going to have a lot of trouble merging patches.

Sarah, mind if I take this one patch?

> USB: xhci: move all debug code under CONFIG_XHCI_HCD_DEBUGGING

Does this conflict with Sarah's other debugging patch she just sent out?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/