Re: [PATCH] ARM: mach-sa1100: Put nanoEngine support back in the kernel.

From: Marcelo Jimenez
Date: Tue Mar 09 2010 - 12:59:25 EST


Hi Kristoffer,

On Tue, Mar 9, 2010 at 13:52, Kristoffer Ericson
<kristoffer.ericson@xxxxxxxxx> wrote:
>
> Without testing it on the actual hardware it applies and looks good, compilation also goes smoothly without any issues.
> It looks quite alright to me. What are you planning to do with the fixup function?

Sorry, this function was the first things I wrote, but the kernel 2.6
infrastructure made it totally unnecessary and it should have been
removed. I will do it and send another patch.

> Im just missing the licensing text in the nano...c file for future reference,

Ok, I will add it too.

> after that feel free to add:
> Acked-by: Kristoffer Ericson <kristoffer.ericson@xxxxxxxxx>
>
> Best wishes
> Kristoffer

Regards,
Marcelo.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/