Re: [PATCH 1/7] HID: N-trig MTM Driver fix and cleanup patch 1

[Jiri Kosina]

On Mon, 8 Mar 2010, Rafi Rubin wrote:

> > + *	1.0 - Rafi Rubin ( Version From 2010-02-13 02:13:05)
> > + *		This cleans up the identification of multitouch
> > + *		groups and enables the end of group sync.
> > + *		Taps are now explicitly handled to adjust for the changes in
> > the
> > + *		event stream in multitouch mode.
> > + *		Added triple and quad tap for the benefit of
> > + *		tools that recognize different tap types but
> > + *		do not have full multi touch support.
> > + *	1.1 - N-trig - Add Change Log and defines of MTM firmware.
> > + *		Add debug Paramater change Driver name in hid_driver structure
> >    */
> 
> I don't know that the change log needs to be in the code file itself. The
> point was more that your commit messages should give us an idea about what
> your changing.  Jiri, what's your take on that?

Fully agreed. I am all for removing any Changelog entries from the .c 
source files altogether. We have excellent SCM to handle this all for us.

> Thank you, we should have named these constants earlier.
> 
> > +#define MODULE_NAME "hid_ntrig"
> > -	.name = "ntrig",
> 
> I left off the "hid_" prefix based on what I saw in the other hid drivers.
> Jiri, is there a standard to follow or do you have an opinion about this?

The convention used by all the other drivers hanging on HID bus are 
without the 'hid' prefix, so we should obey that also for ntrig, yes.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/