Re: sync_mm_rss() issues

From: KAMEZAWA Hiroyuki
Date: Mon Mar 08 2010 - 18:53:55 EST


On Mon, 08 Mar 2010 13:59:56 +0000
David Howells <dhowells@xxxxxxxxxx> wrote:

>
> There are a couple of issues with sync_mm_rss(), as added by patch:
>
> commit 34e55232e59f7b19050267a05ff1226e5cd122a5
> Author: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Date: Fri Mar 5 13:41:40 2010 -0800
> Subject: mm: avoid false sharing of mm_counter
>
> (1) You haven't implemented it for NOMMU mode. What's the right way to do
> this? Just give an empty function?
>
Ah, sorry. I'll prepare empty function immediately. But I have no NOMMU
enviroment...


> (2) linux/mm.h should carry the empty function as an inline when
> CONFIG_SPLIT_RSS_COUNTING=n, rather than it being defined as an empty
> function in mm/memory.c.
>

ok.

please wait..

Sorry,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/