Re: [PATCH] Kernel: Fix coding style in kernel/audit.c

From: Al Viro
Date: Mon Mar 08 2010 - 15:44:18 EST


On Tue, Mar 09, 2010 at 06:27:42AM +0800, wzt.wzt@xxxxxxxxx wrote:
> Fix coding style in kernel/audit.c
>
> Signed-off-by: Zhitong Wang <zhitong.wangzt@xxxxxxxxxxxxxxx>

NACKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
NACKed-because: get a life

> static int audit_set_enabled(int state, uid_t loginuid, u32 sessionid, u32 sid)
> {
> int rc;
> +
> if (state < AUDIT_OFF || state > AUDIT_LOCKED)
> return -EINVAL;
>
> rc = audit_do_config_change("audit_enabled", &audit_enabled, state,
> loginuid, sessionid, sid);
> -
> if (!rc)
> audit_ever_enabled |= !!state;

Seriously, people, please stop that masturbation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/