Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

From: Thibaut VARENE
Date: Sat Feb 27 2010 - 17:18:25 EST


On Sat, Feb 27, 2010 at 5:51 PM, Andrea Gelmini
<andrea.gelmini@xxxxxxxxx> wrote:
> arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
> arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@xxxxxxxxx>
> ---
> Âarch/parisc/include/asm/parport.h | Â Â5 ++---
> Â1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
> index 00d9cc3..5cbf98b 100644
> --- a/arch/parisc/include/asm/parport.h
> +++ b/arch/parisc/include/asm/parport.h

> @@ -8,8 +8,7 @@
> Â#define _ASM_PARPORT_H 1
>
>
> -static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
> -{
> +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {

This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports() is a function, and it's not a fix for
the quoted "WARNING". I'm guessing this wasn't intended the way it is.

HTH

T-Bone

--
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/