Re: [PATCH] sha: prevent removal of memset as dead store in sha1_update()

[roel kluin]

On Thu, Feb 25, 2010 at 5:33 PM, roel kluin <roel.kluin@xxxxxxxxx> wrote:
> On Thu, Feb 25, 2010 at 5:16 PM, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
>> On Thu, Feb 25, 2010 at 5:56 PM, Mikael Pettersson <mikpe@xxxxxxxx> wrote:
>>> I fear that the only portable (across compiler versions) and safe
>>> solution is to invoke an assembly-coded dummy function with prototype
>>>
>>> Â Â Â Âvoid use(void *p);
>>>
>>> and rewrite the code above as
>>>
>>> Â Â Â Â{
>>> Â Â Â Â Â Â Â Âu32 temp[...];
>>> Â Â Â Â Â Â Â Â...
>>> Â Â Â Â Â Â Â Âmemset(temp, 0, sizeof temp);
>>> Â Â Â Â Â Â Â Âuse(temp);
>>> Â Â Â Â}
>>>
>>> This forces the compiler to consider the buffer live after the
>>> memset, so the memset cannot be eliminated.
>>
>> So is there some "do not optimize" GCC magic that we could use for a
>> memzero_secret() helper function?
>>
>> Â Â Â Â Â Â Â Â Â Â Â ÂPekka
>>
>
> Â Â Â Â*(volatile char *)p = *(volatile char *)p;
>
> appears to work when called after the memset:

Or similar to suggested here:

https://www.securecoding.cert.org/confluence/display/cplusplus/MSC06-CPP.+Be+aware+of+compiler+optimization+when+dealing+with+sensitive+data

This memzero_secret() appears to work:

void *memzero_secret(void *v, size_t n) {
        volatile unsigned char *p = v;
        while (n--)
                *p++ = 0;

        return v;
}
---
#include <stdio.h>
#include <string.h>
#include <stdlib.h>

void *memzero_secret(void *v, size_t n) {
	volatile unsigned char *p = v;
	while (n--)
		*p++ = 0;

	return v;
}

void foo()
{
	char password[] = "secret";
	password[0]='S';
	printf ("Don't show again: %s\n", password);
	memzero_secret(password, sizeof(password));
	//memset(password, 0, sizeof(password));
}

int main(int argc, char* argv[])
{
	foo();
	int i;
	char foo3[] = "";
	char* bar = &foo3[0];
	for (i = -50; i < 50; i++)
		printf ("%c.", bar[i]);
	printf("\n");
	return 0;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/