Re: [PATCH] nmi_watchdog: checkpatch.pl cleanups from earlier patches

From: Ingo Molnar
Date: Thu Feb 25 2010 - 06:42:41 EST

Next message: Neil Horman: "Re: [PATCH] supress uid comparison test if core output files arepipes"
Previous message: Jim Dog: "[PATCH] Staging: wlan-ng: Fixed line length issues in prism2usb.c This is a patch to the prism2usb.c that fixes one line which was over the 80 character limit by wrapping it to a new line and removes a commented out configuration for a ZyDAS ZD1201 device since support for this device with this driver is now deprecated. Signed-off-by: Jim Dog <jimdog@northern-indymedia.org>"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

* Don Zickus <dzickus@xxxxxxxxxx> wrote:

> Mostly copy/paste whitespace damage with a couple of nitpicks by the script.
> Fix the struct definition as requested by Ingo too.
>
> Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> --
> Ingo,
>
> I don't know how you want this patch. Like this to put on top or do you
> want me to repost everything with the cleanups inside the appropriate patch?

It's fine this way - i've put them on top - the base patches have a reasonable
amount of testing track record already, we dont want to destroy that via a
rebase.

(in the future it's useful to run checkpatch as part of your patch submission
checks. In my experience it finds real issues most of the time. Some of the
warnings have to be ignored.)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/