Re: [PATCH] failslab: add abitily to filter slab caches

[Akinobu Mita]

2010/2/23 Dmitry Monakhov <dmonakhov@xxxxxxxxxx>:
> Akinobu Mita <akinobu.mita@xxxxxxxxx> writes:
>
>> 2010/2/23 Dmitry Monakhov <dmonakhov@xxxxxxxxxx>:
>>> Example:
>>> echo 1 > /sys/kernel/slab/skbuff_head_cache/failslab
>>> echo 1 > /sys/kernel/debug/failslab/cache-filter
>>
>> Looks good.
>>
>> .Should we also support clearing the flag by
>> "echo 0 > /sys/kernel/slab/skbuff_head_cache/failslab" ?
> But it already does this, any output except "1" treated as '0'
> I've snipped this from trace option.

Oops, you are right.

>>
>>> +static ssize_t failslab_store(struct kmem_cache *s, const char *buf,
>>> +                                                       size_t length)
>>> +{
>>> +       s->flags &= ~SLAB_FAILSLAB;
>>> +       if (buf[0] == '1')
>>> +               s->flags |= SLAB_FAILSLAB;
>>> +       return length;
>>> +}
>>> +SLAB_ATTR(failslab);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/